[youporn] Fix extraction of video URLs #8827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API seems to be gone, but video_player_setup object will contain playervars, with URLs to fetch the format definitions.
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
Mar 8, 2024
* from yt-dlp/yt-dlp#8827 * extract from webpage instead of broken API URL * thx The-MAGI
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
Mar 10, 2024
* from yt-dlp/yt-dlp#8827 * extract from webpage instead of broken API URL * thx The-MAGI
11 tasks
|
This is the failing Linter output (CI log now expired): $ flake8 yt_dlp/extractor/youporn.py
yt_dlp/extractor/youporn.py:4:1: F401 '..utils.url_or_none' imported but unused
yt_dlp/extractor/youporn.py:98:38: E203 whitespace before ':'
yt_dlp/extractor/youporn.py:101:16: E713 test for membership should be 'not in'
$ |
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
Apr 12, 2024
* from yt-dlp/yt-dlp#8827 * extract from webpage instead of broken API URL * thx The-MAGI
dirkf
added a commit
to ytdl-org/youtube-dl
that referenced
this pull request
Apr 22, 2024
* from yt-dlp/yt-dlp#8827 * extract from webpage instead of broken API URL * thx The-MAGI
dirkf
added a commit
to ytdl-org/ytdl-nightly
that referenced
this pull request
Apr 22, 2024
* from yt-dlp/yt-dlp#8827 * extract from webpage instead of broken API URL * thx The-MAGI
github-actions bot
added a commit
to hellopony/youtube-dl
that referenced
this pull request
Apr 22, 2024
* https://github.com/ytdl-org/youtube-dl: [YouPorn] Add playlist extractors * YouPornCategoryIE * YouPornChannelIE * YouPornCollectionIE * YouPornStarIE * YouPornTagIE * YouPornVideosIE, [YouPorn] Improve extraction * detect unwatchable videos * improve duration extraction * fix count extraction and support large values * detect and remove SEO spam boilerplate description [test/test_download] Support 'playlist_maxcount:count' expected value * parallel to `playlist_mincount' * specify both for a range of playlist lengths * if max < min the test will always fail! [YouPorn] Incorporate yt-dlp PR 8827 * from yt-dlp/yt-dlp#8827 * extract from webpage instead of broken API URL * thx The-MAGI
Authored by: bashonly
Authored by: bashonly
bashonly
removed
pending-fixes
bashonly
approved these changes
May 5, 2024
Authored by: bashonly
Authored by: bashonly
Authored by: bashonly
Authored by: bashonly
Authored by: bashonly
Grub4K
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API seems to be gone, but video_player_setup object will contain playervars, with URLs to fetch the format definitions.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Fixes extraction of YouPorn video URLs. The API seems to be gone, but
video_player_setupobject will containplayervars, with URLs to fetch the format definitions.Fixes #7967.
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?