-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Prankcast] Fix extractor and add live chat #8933
Conversation
You should not break the old URLs, which still work. You can specify the |
Added the The /showreel/ URLs have been deprecated for a while. They are no longer accessible directly from the site, all links now point to the /posts/ path. It's missing a few of the fields I'm using on the new extractor as well. I can try to add support for /showreel/ back but I'm not sure whats the point of keeping them around... |
Done, I've added the PrankCastPostIE for the new URLs |
|
Thanks! I'll check those out and see if I end up figuring it out. I'll probably push that feature as a new PR tho, I won't be able to work on the live extractor for a while. |
Authored by: columndeeply
Authored by: columndeeply
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
This PR fixes the old extractor and adds support for live chat downloading.
I'm not sure if I'm doing it correctly but it's saving the subtitles file as ".live_chat.unknown_video"... Not sure what that means... The contents of the chat JSON are saved correctly so that part seems to work.
I also wanted to add livestream support but couldn't figure out how to. If anybody could point me to an existing extractor that supports both livestreams and non-live media (and is simpler than the YouTube one... I was following that but no luck...) I'd appreciate it. If I end up figuring it out I'll make a new PR with that feature.
Fixes #
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?