Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aenetworks] Prevent missing ratings extractor crash #9005

Merged
merged 2 commits into from Jan 18, 2024

Conversation

agibson-fl
Copy link
Contributor

@agibson-fl agibson-fl commented Jan 15, 2024

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Certain shows without ratings on AE networks will crash and not allow the download to complete.
To duplicate this:
yt-dlp -V https://play.history.com/shows/kennedy/season-1/episode-2
or
yt-dlp -V https://play.history.com/shows/kennedy/season-1/episode-3
(not sure if one will get ratings in the meantime of this being merged and prevent duplication)

I found code already in this project from the amcnetworks.py extractor that fixes the problem there. I copied that code over to the aenetworks.py and tested it manually. It works.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

yt_dlp/extractor/aenetworks.py Outdated Show resolved Hide resolved
yt_dlp/extractor/aenetworks.py Outdated Show resolved Hide resolved
yt_dlp/extractor/aenetworks.py Outdated Show resolved Hide resolved
@bashonly bashonly added site-bug Issue with a specific website pending-fixes PR has had changes requested labels Jan 15, 2024
@agibson-fl
Copy link
Contributor Author

agibson-fl commented Jan 15, 2024

@bashonly I pushed the requested changes. The code no longer looks like the convention used in amcnetworks.py, but your suggested changes are cleaner anyway. (I was trying to fit the code in with the other extractors that had this problem)

@bashonly bashonly removed the pending-fixes PR has had changes requested label Jan 15, 2024
@bashonly bashonly merged commit 014cb57 into yt-dlp:master Jan 18, 2024
6 checks passed
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants