Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/radiko]add Metadata info (performer, duration) #9115

Merged

Conversation

YoshichikaAAA
Copy link
Contributor

@YoshichikaAAA YoshichikaAAA commented Jan 31, 2024

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Adds the following information as metadata that can be obtained from radiko.jp for the target program:

  • Performers
  • Duration
Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@pukkandan
Copy link
Member

  • (Make sure to add/update tests)

@pukkandan pukkandan added site-enhancement Feature request for some website pending-fixes PR has had changes requested labels Jan 31, 2024
yt_dlp/extractor/radiko.py Outdated Show resolved Hide resolved
yt_dlp/extractor/radiko.py Outdated Show resolved Hide resolved
@YoshichikaAAA
Copy link
Contributor Author

  • (Make sure to add/update tests)

This site (radiko.jp) provides Japanese radio programs with live streaming and on-demand.
The metadata for live streaming, such as performer, program duration, dynamically changes depending on the time of execution.
Additionally, on-demand streaming is available for only one week after the broadcast.
Furthermore, it is only accessible within Japan, and channels available for viewing are exclusive to each prefecture determined by IP addresses.

In the original source code, the tests specifically target URL detection only.
Considering it will be executed in CI, creating tests beyond the current scope is difficult.

yt_dlp/extractor/radiko.py Outdated Show resolved Hide resolved
yt_dlp/extractor/radiko.py Outdated Show resolved Hide resolved
yt_dlp/extractor/radiko.py Outdated Show resolved Hide resolved
yt_dlp/extractor/radiko.py Outdated Show resolved Hide resolved
yt_dlp/extractor/radiko.py Outdated Show resolved Hide resolved
@bashonly bashonly added pending-review PR needs a review and removed pending-fixes PR has had changes requested labels Feb 1, 2024
@seproDev seproDev removed the pending-review PR needs a review label Feb 3, 2024
@bashonly bashonly merged commit e3ce2b3 into yt-dlp:master Feb 3, 2024
6 checks passed
FletcherD pushed a commit to FletcherD/yt-dlp that referenced this pull request Feb 14, 2024
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-enhancement Feature request for some website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants