Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ie/niconico] Add support for DMS server; use robust info extraction logic; allow empty danmaku #9282

Merged
merged 20 commits into from
Feb 29, 2024
Merged

[ie/niconico] Add support for DMS server; use robust info extraction logic; allow empty danmaku #9282

merged 20 commits into from
Feb 29, 2024
+114 −46

Commits on Feb 24, 2024

  1. [ie/niconico] Add support for DMS server 

    This commit cannot be finished without @xpadev-net's work.

Co-authored-by: XPA <96982836+xpadev-net@users.noreply.github.com>
    @pzhlkj6612 @xpadev-net
    pzhlkj6612 and xpadev-net committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    dceb419 View commit details
    Browse the repository at this point in the history

  2. [ie/niconico] Only extract info from valid JSON data 

    We are not able to check if the video is behind a paywall, login
  required or geo-restricted.
    @pzhlkj6612
    pzhlkj6612 committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    3b64cc7 View commit details
    Browse the repository at this point in the history

  3. [ie/niconico] Do not fetch comments if no comments info

    @pzhlkj6612
    pzhlkj6612 committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    0425971 View commit details
    Browse the repository at this point in the history

  4. [ie/niconico] Videos without any comments are valid 

    For comments' download, we don't need to care about if the video is
  members-only. No comments means no comments.
    @pzhlkj6612
    pzhlkj6612 committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    c13c6e1 View commit details
    Browse the repository at this point in the history

  5. [ie/niconico] Detect members-only videos

    @pzhlkj6612
    pzhlkj6612 committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    64c2eed View commit details
    Browse the repository at this point in the history

  6. [ie/niconico] clean imports

    @pzhlkj6612
    pzhlkj6612 committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    19b68d1 View commit details
    Browse the repository at this point in the history

  7. [ie/niconico] Amend tests; those tests are still not working 

    test_download.py:239: self.assertTrue(tc_filename in finished_hook_called)

How to solve it?
    @pzhlkj6612
    pzhlkj6612 committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    522d9d1 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. [ie/niconico] clean html by clean_html() 

    Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
    @pzhlkj6612 @bashonly
    pzhlkj6612 and bashonly committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    b94ff57 View commit details
    Browse the repository at this point in the history

  2. [ie/niconico] try getting danmaku if server‘s url obtained 

    Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
    @pzhlkj6612 @bashonly
    pzhlkj6612 and bashonly committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    7177148 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. [ie/niconico] DMC: simplify extraction; rm useless function; add asr 

    Labels are "1080p", "720p", "480p", "360p" and "144p", so the
  "extract_video_quality" function will not work.

Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
    @pzhlkj6612 @bashonly
    pzhlkj6612 and bashonly committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    9a986b9 View commit details
    Browse the repository at this point in the history

  2. [ie/niconico] rewrite DMS info extraction by splitting transformations

    @pzhlkj6612
    pzhlkj6612 committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    ba7950e View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Apply suggestions from code review

    @bashonly
    bashonly committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    e2ba100 View commit details
    Browse the repository at this point in the history

  2. refactor

    @bashonly
    bashonly committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    711080b View commit details
    Browse the repository at this point in the history

  3. add comment

    @bashonly
    bashonly committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    cfc1c74 View commit details
    Browse the repository at this point in the history

  4. cleanup

    @bashonly
    bashonly committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    4ee0c58 View commit details
    Browse the repository at this point in the history

  5. oops

    @bashonly
    bashonly committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    8348747 View commit details
    Browse the repository at this point in the history

  6. inline formats extraction

    @bashonly
    bashonly committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    668275b View commit details
    Browse the repository at this point in the history

  7. more cleanup

    @bashonly
    bashonly committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    0173324 View commit details
    Browse the repository at this point in the history

  8. final cleanup

    @bashonly
    bashonly committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    eaba4d1 View commit details
    Browse the repository at this point in the history

  9. final final cleanup

    @bashonly
    bashonly committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    6b95ddb View commit details
    Browse the repository at this point in the history