Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JioCinema] Add extractor #9349

Closed
wants to merge 1 commit into from

Conversation

Rajeshwaran2001
Copy link
Contributor

@Rajeshwaran2001 Rajeshwaran2001 commented Mar 3, 2024

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

ADD DESCRIPTION HERE

Fixes #5563

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@bashonly
Copy link
Member

bashonly commented Mar 3, 2024

Hm, a lot of this code looks very familiar

@Rajeshwaran2001
Copy link
Contributor Author

Hm, a lot of this code looks very familiar

yeah i got most of the code from your repo and added little tweaks

@bashonly bashonly added the site-request Request to support a new website label Mar 3, 2024
@pukkandan
Copy link
Member

Avoid so much copy-paste. Derive the desired functionality from a baseclass

@shortthirdman
Copy link

@bashonly @pukkandan When is this PR going to be merged into release? Just waiting to use it for testing.

@pukkandan pukkandan added the pending-fixes PR has had changes requested label Mar 12, 2024
@Rajeshwaran2001
Copy link
Contributor Author

@bashonly @pukkandan When is this PR going to be merged into release? Just waiting to use it for testing.

you can get the build https://github.com/DRM-Media-Tool/yt-dlp/releases/tag/2024.03.09.093349

@shortthirdman
Copy link

@bashonly @pukkandan When is this PR going to be merged into release? Just waiting to use it for testing.

you can get the build https://github.com/DRM-Media-Tool/yt-dlp/releases/tag/2024.03.09.093349

@Rajeshwaran2001 Build is not stable. Tested with couple of free videos, both of them failed in the download stage throwing error as ERROR: unable to download video data: HTTP Error 400: Bad Request.

Full log below:

$PS> $jio = 'https://www.jiocinema.com/tv-shows/udaariyaan/1/tejo-loses-fateh/3523229'
$PS> .\yt.exe -f "hls-1328-1+ba" -P "$pwd" -o "S%(season_number)s E%(episode_number)s - %(upload_date>%#d %B %Y)s - %(episode)s.%(ext)s" $jio

[JioCinema] Extracting URL: https://www.jiocinema.com/tv-shows/udaariyaan/1/tejo-loses-fateh/3523229
[JioCinema] Downloading guest token
[JioCinema] Fetching Metadata
[JioCinema] 3523229: Downloading playback JSON
[JioCinema] 3523229: Downloading MPD manifest
[JioCinema] 3523229: Downloading m3u8 information
[info] 3523229: Downloading 1 format(s): hls-1328-1+hls-A64-aac
[info] There are no subtitles for the requested languages
[info] Downloading video thumbnail 0 ...
[info] Writing video thumbnail 0 to: D:\Entertainment - TV Shows\NEXT\S1 E341 - 5 April 2022 - Tejo loses Fateh!.jpg
[info] Writing video metadata as JSON to: D:\Entertainment - TV Shows\NEXT\S1 E341 - 5 April 2022 - Tejo loses Fateh!.info.json
[hlsnative] Downloading m3u8 manifest
[hlsnative] Total fragments: 217
[download] Destination: D:\Entertainment - TV Shows\NEXT\S1 E341 - 5 April 2022 - Tejo loses Fateh!.fhls-1328-1.mp4
[download]   0.2% of ~ 315.69MiB at  194.33KiB/s ETA 37:08 (frag 1/217)ERROR: unable to download video data: HTTP Error 400: Bad Request

Did you test it out yourself first before the PR?

@yt-dlp yt-dlp deleted a comment from Rajeshwaran2001 Mar 14, 2024
@yt-dlp yt-dlp locked and limited conversation to collaborators Mar 14, 2024
@bashonly bashonly closed this in 1463945 May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pending-fixes PR has had changes requested site-request Request to support a new website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jio cinema Extractor
4 participants