New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ie/roosterteeth] Add Brightcove fallback #9403
Conversation
Authored by: bashonly
There was a talk on the previous PR about extracting bonus content. This PR is unrelated to that, am I right? |
@NBruderman yes, unrelated. I don't even know how to do it, so someone else needs to open a PR for that |
Thank you for getting this together so quickly. I can confirm it works for the most part for videos previously failing with 403 errors, but is this workaround limited in format? I've found that running with |
These are the only formats available to the browser as well |
To clarify, here are the formats available for https://roosterteeth.com/watch/lets-play-2013-126:
If I set
I wasn't sure if the brightcove ID changed per format or something? |
No. I can reproduce the issue with the 720p format. But I also can't get it to play in my browser. Can you? I don't see a way of fixing this. As it stands, this PR is an improvement over doing nothing, since at least you can get the 1080p format. |
Good question. It says it's switching resolution streams in the network logs but the video quality doesn't noticeably change from 240p to 1080p so probably not. And I totally agree that this PR is exactly what's needed, I was just checking if I was missing something. Thanks! |
Authored by: bashonly
Authored by: bashonly
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?