Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ssl keys log using SSLKEYLOGFILE env var for SSLContext (yt-dlp/yt-dlp#9531) #9543

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Adding ssl keys log using SSLKEYLOGFILE env var for SSLContext (yt-dlp/yt-dlp#9531) #9543

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ee1c14
Adding ssl keys log using SSLKEYLOGFILE env var for SSLContext (yt-dl…
luiso1979 Mar 27, 2024
2a2f5bf
added check for keylog_filename inside ssl context (for older python)…
luiso1979 Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions yt_dlp/networking/_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import contextlib
import functools
import os
import socket
import ssl
import sys
Expand Down Expand Up @@ -121,6 +122,9 @@ def make_ssl_context(
context = ssl.SSLContext(ssl.PROTOCOL_TLS_CLIENT)
context.check_hostname = verify
context.verify_mode = ssl.CERT_REQUIRED if verify else ssl.CERT_NONE
# OpenSSL 1.1.1+ Python 3.8+ keylog file
if hasattr(context, 'keylog_filename'):
context.keylog_filename = os.environ.get('SSLKEYLOGFILE')

# Some servers may reject requests if ALPN extension is not sent. See:
# https://github.com/python/cpython/issues/85140
Expand Down