New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ie/tiktok] Fix API extraction #9548
Merged
Merged
+113
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Authored by: bashonly
Authored by: bashonly
Authored by: bashonly
Authored by: bashonly
Authored by: bashonly
Authored by: bashonly
pukkandan
reviewed
Mar 28, 2024
pukkandan
reviewed
Mar 28, 2024
pukkandan
reviewed
Mar 28, 2024
bashonly
added
pending-fixes
PR has had changes requested
pending-review
PR needs a review
and removed
pending-fixes
PR has had changes requested
labels
Mar 28, 2024
seproDev
approved these changes
Mar 29, 2024
pukkandan
approved these changes
Mar 29, 2024
Authored by: bashonly
Authored by: bashonly
Grub4K
approved these changes
Mar 29, 2024
Sorry if I'm writing in the wrong topic, but this fix downloads some videos with an strange codec Formats:
Example:
|
@JailSeed can you open a new issue please? |
Sure |
haccy
pushed a commit
to haccy/yt-dlp
that referenced
this pull request
Mar 30, 2024
Closes yt-dlp#9506 Authored by: bashonly, Grub4K Co-authored-by: Simon Sawicki <contact@grub4k.xyz>
9 tasks
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Closes yt-dlp#9506 Authored by: bashonly, Grub4K Co-authored-by: Simon Sawicki <contact@grub4k.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mobile API feed endpoint that is used to extract high-resolution/no-watermark formats has begun checking/enforcing the
iid
(install id) query param for requests made to it.A unique install ID is assigned to the mobile app installation by the TT API upon device registration. This PR hardcodes 3 of them that were donated for use in the extractor. The app versions fallback/cache loop has been replaced by an install IDs fallback/cache loop (since having multiple app versions hasn't been useful for quite some time).
The PR also adds aniid
extractor-arg so that users can bring their own install ID if they so wish (or if the hardcodediid
s are failing). This also necessitated anapp_name
extractor-arg,The PR adds an
app_info
extractor-arg, which allows one or more strings in the format of<iid>/[app_name]/[app_version]/[manifest_app_version]/[aid]
to be passed, since any given install ID is tethered to the app variant it was assigned to (trill
for KR/PH/TW/TH/VN ormusical_ly
for rest of world) and each variant has its own versioning andaid
(app ID).Closes #9506
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?