Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ie/youtube] Extract comments with or without new format #9775

Merged
merged 28 commits into from
May 17, 2024
Merged

[ie/youtube] Extract comments with or without new format #9775

merged 28 commits into from
May 17, 2024

Commits on Apr 23, 2024

  1. apply patch from issues/9358#issuecomment-2072600506

    @jakeogh
    jakeogh committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    ee81ca4 View commit details
    Browse the repository at this point in the history

  2. fix typo in previous patch, like count, and use direct dict access

    @jakeogh
    jakeogh committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    16cb4fe View commit details
    Browse the repository at this point in the history

  3. handle KeyError: 'frameworkUpdates' when the old comment format is se… 

    …rved
    @jakeogh
    jakeogh committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    6083596 View commit details
    Browse the repository at this point in the history

  4. fix old comment extraction

    @jakeogh
    jakeogh committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    2ef6563 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. fix like_count

    @jakeogh
    jakeogh committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    4da1db9 View commit details
    Browse the repository at this point in the history

  2. fix indent

    @jakeogh
    jakeogh committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    800906c View commit details
    Browse the repository at this point in the history

  3. fix another indent

    @jakeogh
    jakeogh committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    2763473 View commit details
    Browse the repository at this point in the history

  4. replace dict access with try_get()

    @jakeogh
    jakeogh committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    17bb443 View commit details
    Browse the repository at this point in the history

  5. replace dict access with traverse_obj() and use likeCountA11y

    @jakeogh
    jakeogh committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    3ef6517 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. add commentRenderer fix from @minamotorin

    @jakeogh
    jakeogh committed May 6, 2024
    Configuration menu
    Copy the full SHA
    a1102d7 View commit details
    Browse the repository at this point in the history

  2. apply patch from @minamotorin of example code by @shoxie007

    @jakeogh
    jakeogh committed May 6, 2024
    Configuration menu
    Copy the full SHA
    f4c1de1 View commit details
    Browse the repository at this point in the history

  3. @bbilly1 correctly parse like_count for cases > 1000

    @jakeogh
    jakeogh committed May 6, 2024
    Configuration menu
    Copy the full SHA
    5a3a4f1 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. two whitespace fixes

    @jakeogh
    jakeogh committed May 15, 2024
    Configuration menu
    Copy the full SHA
    cf9751a View commit details
    Browse the repository at this point in the history

  2. use traverse_obj with mutations variable

    @jakeogh
    jakeogh committed May 15, 2024
    Configuration menu
    Copy the full SHA
    f09e66b View commit details
    Browse the repository at this point in the history

  3. fix test for None

    @jakeogh
    jakeogh committed May 15, 2024
    Configuration menu
    Copy the full SHA
    1a0cf3c View commit details
    Browse the repository at this point in the history

  4. remove .get() call from content

    @jakeogh
    jakeogh committed May 15, 2024
    Configuration menu
    Copy the full SHA
    4701ad6 View commit details
    Browse the repository at this point in the history

  5. move continue block, filter() comment_keys for None

    @jakeogh
    jakeogh committed May 15, 2024
    Configuration menu
    Copy the full SHA
    6f5c669 View commit details
    Browse the repository at this point in the history

  6. use get_first() and remove .get()

    @jakeogh
    jakeogh committed May 15, 2024
    Configuration menu
    Copy the full SHA
    f6ced29 View commit details
    Browse the repository at this point in the history

  7. use single traversal

    @jakeogh
    jakeogh committed May 15, 2024
    Configuration menu
    Copy the full SHA
    8d428b4 View commit details
    Browse the repository at this point in the history

  8. use traverse_obj for time_text

    @jakeogh
    jakeogh committed May 15, 2024
    Configuration menu
    Copy the full SHA
    0ef6c93 View commit details
    Browse the repository at this point in the history

  9. whitespace change

    @jakeogh
    jakeogh committed May 15, 2024
    Configuration menu
    Copy the full SHA
    1cee8e7 View commit details
    Browse the repository at this point in the history

  10. remove pinned_text var

    @jakeogh
    jakeogh committed May 15, 2024
    Configuration menu
    Copy the full SHA
    743ed06 View commit details
    Browse the repository at this point in the history

  11. add {bool}

    @jakeogh
    jakeogh committed May 15, 2024
    Configuration menu
    Copy the full SHA
    1adea35 View commit details
    Browse the repository at this point in the history

  12. fix author_is_verified

    @jakeogh
    jakeogh committed May 15, 2024
    Configuration menu
    Copy the full SHA
    1872982 View commit details
    Browse the repository at this point in the history

  13. use single traversal pattern

    @jakeogh
    jakeogh committed May 15, 2024
    Configuration menu
    Copy the full SHA
    90b1129 View commit details
    Browse the repository at this point in the history

  14. readability

    @pukkandan
    pukkandan committed May 15, 2024
    Configuration menu
    Copy the full SHA
    54b823b View commit details
    Browse the repository at this point in the history

  15. Apply suggestions from code review

    @bashonly
    bashonly committed May 15, 2024
    Configuration menu
    Copy the full SHA
    053cde7 View commit details
    Browse the repository at this point in the history

  16. use traversal and check for comment_keys

    @bashonly
    bashonly committed May 15, 2024
    Configuration menu
    Copy the full SHA
    47a6fb7 View commit details
    Browse the repository at this point in the history