New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ie/yandexvideo] Fix extractor #9813
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls update relevant tests. or add new ones if there is none
It was more of the case that previous tests were not working than supporting something new/different but alright, will make a new test. |
No need. But are the existing tests passing now? |
Yes: (venv) [linux@linux yt-dlp]$ python3 devscripts/run_tests.py ZenYandex_all
Running ['pytest', '-Werror', '--tb=short', 'test/test_download.py::TestDownload::test_ZenYandex_all']
=========================================================================================================== test session starts ============================================================================================================
platform linux -- Python 3.11.8, pytest-8.2.0, pluggy-1.5.0 -- /home/linux/git/yt-dlp/venv/bin/python
cachedir: .pytest_cache
rootdir: /home/linux/git/yt-dlp
configfile: setup.cfg
collected 1 item
test/test_download.py::TestDownload::test_ZenYandex_all PASSED [100%]
============================================================================================================ 1 passed in 35.88s ============================================================================================================ |
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
The site has changed their JSON format, causing the failure of stream urls extraction. Basically this patch extracts stream urls from the new JSON format
Fixes #9803
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?