Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest --list-subs when no matching subtitle format found (Resolve #9760) #9873

Merged
merged 2 commits into from
May 11, 2024

Conversation

wenbang24
Copy link
Contributor

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Added "add the --list-subs flag to see a list of available subtitle formats" to YoutubeDL.py.

also its my first issue :)

Fixes #9760

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Added "add the --list-subs flag to see a list of available subtitle formats"
@pukkandan pukkandan changed the title Resolve #9760 Suggest --list-subs when no matching subtitle format found (Resolve #9760) May 6, 2024
yt_dlp/YoutubeDL.py Outdated Show resolved Hide resolved
@pukkandan pukkandan added the enhancement New feature or request label May 6, 2024
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
Copy link
Member

@bashonly bashonly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. In the future, please do not resolve review comments unless you are directly applying the suggested change(s)

@wenbang24
Copy link
Contributor Author

so what do I do now?

@seproDev
Copy link
Collaborator

Nothing to do from your side. At some point a maintainer will merge this.

@bashonly bashonly merged commit 7e4259d into yt-dlp:master May 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggest --list-subs when no matching subtitle format found
4 participants