Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/tiktok] Fix subtitles extraction #9961

Merged
merged 3 commits into from
May 22, 2024
Merged

Conversation

bashonly
Copy link
Member

Subs extraction was broken; the feed API responses no longer have subs info, and the webpage parsing method wasn't returning them.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense

What is the purpose of your pull request?

  • Fix or improvement to an extractor (Make sure to add/update tests)

@bashonly bashonly added the site-bug Issue with a specific website label May 18, 2024
yt_dlp/extractor/tiktok.py Outdated Show resolved Hide resolved
@bashonly bashonly merged commit eef1e9f into yt-dlp:master May 22, 2024
6 checks passed
@bashonly bashonly deleted the fix/tiktok-subs branch May 22, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant