-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SponsorBlock merge algorithm improvements #999
Conversation
Signed-off-by: nihil-admirari <50202386+nihil-admirari@users.noreply.github.com>
Sorry about that. I don't remember whether I pushed with/without leash, but I do remember seeing and reviewing that commit. So not sure what happened. No point in mulling over it now - I'll try to be more careful in the future.
I don't currently have time to properly test this. But if you have tested everything and is confident, I can merge it
I had pretty much forgotten about this. I'll cherrypick it
Can't the same be said about most other postprocessing operations? We'll need to think about how to implement this without needing a new switch for each one PS: btw, why not just use download-archive for this? |
There are unit test for all of these changes. However, after reviewing the code once more, I decided that summing durations is not needed. Since sponsors are no longer merged into one, but rather separated into before overlap, overlap, and after overlap, the overlap part rarely contains more than two sponsors. Even in edge cases when it does, picking the absolute smallest contributor is probably better than picking the category with lowest total duration. I've added a test for smallest chapter determination anyway.
I forgot to remove old format handling code in the updater, which is now fixed.
Didn't know that |
…sors Signed-off-by: nihil-admirari <50202386+nihil-admirari@users.noreply.github.com>
I dropped hashing-related commits. Only SponsorBlock changes remain. |
Authored by: nihil-admirari
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Multiple small fixes:
sponsor-block
branch fromeb3c813
toe10ef4c
15 days ago). Please consider using --force-with-lease the next time.Standardized SHA256 hash sums.Hash sums for TAR archive are currently missing.Incorporated into [build] Improve release process #880.Since the fixes are tiny, they are combined into one pull request. Cherry-pick whatever you find useful.