BUG: fix incompatibilities with NumPy 2.1 #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Normal CI is affected now that NumPy 2.1 is out (though it is not the only issue) |
neutrinoceros
changed the title
neutrinoceros
changed the title
neutrinoceros
commented
Aug 19, 2024
Comment on lines
+272
to
+273
| >>> with np.printoptions(precision=4): | ||
| ... print([1.123456789]*u.km) |
There was a problem hiding this comment.
the reason this fix is needed is that the repr of np.set_printoptions's return value is not empty in numpy 2.1, which caused this test to fail and leak side effects, causing a lot other tests to fail too.
jzuhone
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example logs
xref: numpy/numpy#26724