Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pooch to obtain OWLS ionization data #2476

Open
matthewturk opened this issue Mar 9, 2020 · 3 comments
Open

Use pooch to obtain OWLS ionization data #2476

matthewturk opened this issue Mar 9, 2020 · 3 comments
Labels
new contributor friendly Good for new contributors! new feature Something fun and new!

Comments

@matthewturk
Copy link
Member

Now that Pooch support has been merged (#2417 ) we should use pooch to download ionization data for the OWLS frontend instead of manually.

@triage-new-issues triage-new-issues bot added the triage Triage needed label Mar 9, 2020
@munkm munkm added new contributor friendly Good for new contributors! new feature Something fun and new! labels Mar 9, 2020
@triage-new-issues triage-new-issues bot removed the triage Triage needed label Mar 9, 2020
@munkm
Copy link
Member

munkm commented Mar 9, 2020

This is a great issue for a new contributor to the project. To do this, you'll want to modify the portion of yt/frontends/owls/fields.py to use pooch to download the ionization data (see the following lines: https://github.com/yt-project/yt/blob/master/yt/frontends/owls/fields.py#L286-L310). The linked PR has some examples of using pooch to download data.

I think because pooch is an optional dependency on install for us, it would be worth talking about what the behavior should be if a user doesn't have pooch installed and this data is attempted to be downloaded. Do we want to fall back using the current behavior? Or issue a warning?

@zackcd
Copy link

zackcd commented Apr 22, 2020

May I try to work on this if still needed? Thanks.

@matthewturk
Copy link
Member Author

matthewturk commented Apr 22, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new contributor friendly Good for new contributors! new feature Something fun and new!
Projects
None yet
Development

No branches or pull requests

3 participants