Adding testcases for visualization.image_writer #1842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-abhishek
force-pushed
the
viz-image-writer
branch
from
0a4f66d
to
862c42a
Compare
git-abhishek
force-pushed
the
viz-image-writer
branch
from
862c42a
to
e1c7242
Compare
ngoldbaum
reviewed
Jun 27, 2018
yt/visualization/image_writer.py
Outdated
| if len(bitmap_array.shape) != 3 or bitmap_array.shape[-1] not in (3,4): | ||
| raise RuntimeError | ||
| if len(bitmap_array.shape) != 3 or bitmap_array.shape[-1] not in (3, 4): | ||
| raise YTException(message="Expecting image array of shape (N,M,3)" |
There was a problem hiding this comment.
I'd just use RuntimeError instead of YTException here.
yt/visualization/image_writer.py
Outdated
| @@ -295,8 +299,8 @@ def strip_colormap_data(fn = "color_map_data.py", | |||
| f.write("from numpy import array\n") | |||
| f.write("color_map_luts = {}\n\n\n") | |||
| if cmaps is None: cmaps = rcm.ColorMaps | |||
| if isinstance(cmaps, string_types): cmaps = [cmaps] | |||
There was a problem hiding this comment.
carriage return after the colon
| if suffix == ".png": | ||
| canvas = FigureCanvasAgg(fig) | ||
| elif suffix == ".pdf": | ||
| if suffix == ".pdf": |
There was a problem hiding this comment.
Can you restore the logic that was originally here? We want the warning message about the unknown suffix I think.
There was a problem hiding this comment.
get_image_suffix(filename) returns ['.png', '.eps', '.ps', '.pdf', ''] thus, it will never execute the original else block.
| import tempfile | ||
| import unittest | ||
|
|
||
| from yt.mods import write_projection |
There was a problem hiding this comment.
import this from yt.visualization.image_writer.
| # Test remaining parameters of write_projection | ||
| write_projection(image, "test_2", xlabel="x-axis", ylabel="y-axis") | ||
| write_projection(image, "test_3.pdf", xlabel="x-axis", ylabel="y-axis") | ||
| write_projection(image, "test_4.eps", xlabel="x-axis", ylabel="y-axis") |
There was a problem hiding this comment.
Can you test to make sure these images are actually written to disk and are in the correct format? See the assert_fname function in yt.testing
git-abhishek
commented
Jun 27, 2018
yt/visualization/image_writer.py
Outdated
| if len(bitmap_array.shape) != 3 or bitmap_array.shape[-1] not in (3,4): | ||
| raise RuntimeError | ||
| if len(bitmap_array.shape) != 3 or bitmap_array.shape[-1] not in (3, 4): | ||
| raise YTException(message="Expecting image array of shape (N,M,3)" |
yt/visualization/image_writer.py
Outdated
| @@ -295,8 +299,8 @@ def strip_colormap_data(fn = "color_map_data.py", | |||
| f.write("from numpy import array\n") | |||
| f.write("color_map_luts = {}\n\n\n") | |||
| if cmaps is None: cmaps = rcm.ColorMaps | |||
| if isinstance(cmaps, string_types): cmaps = [cmaps] | |||
| import tempfile | ||
| import unittest | ||
|
|
||
| from yt.mods import write_projection |
| # Test remaining parameters of write_projection | ||
| write_projection(image, "test_2", xlabel="x-axis", ylabel="y-axis") | ||
| write_projection(image, "test_3.pdf", xlabel="x-axis", ylabel="y-axis") | ||
| write_projection(image, "test_4.eps", xlabel="x-axis", ylabel="y-axis") |
|
@yt-fido test this please |
1 similar comment
|
@yt-fido test this please |
ngoldbaum
approved these changes
Jul 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Adding testcases for
visualization.image_writerPR Checklist
Adding Reviewers
@ngoldbaum @Xarthisius @colinmarc