-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Improvements to reading / writing FITS images #2010
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzuhone
force-pushed
the
fits
branch
2 times, most recently
from
September 14, 2018 14:55
404d332
to
efc6ea8
Compare
@yt-fido test this please |
merging yt-4.0 with master
These are for new warnings introduced that we do not want to follow.
…ale if a subclass defines it
…ss the user specifies otherwise
…eader in the FITSDataset class
…t spectrum as 3rd dimension
Closing this because I've rebased on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces improvements to FITS file writing and reading. Specifically:
FITSImageData
class and its subclasses. This standard uses the header to write unit information and other metadata to the FITS file so that when it is read back into yt as a dataset it is more self-describing.YTFITSDataset
, which is a subclass ofFITSDataset
which looks specifically for this header metadata.FITSHierarchy
for determining units."beam"
unit part ofSkyDataFITSDataset
.convolve
method toFITSImageData
instances to convolve them with any kernel created using AstroPy or a simple Gaussian kernel.FITSImageData
subclasses should be 512. The previous behavior was inconsistent across the various subclasses.The new yt-based standard for writing FITS datasets with self-describing information and reading them back in as datasets is set out in a YTEP:
yt-project/ytep#5
Things left to do:
YTCoveringGrid
to write these grids to FITS files