Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Improvements to reading / writing FITS images #2010

Closed
wants to merge 1,145 commits into from

Conversation

jzuhone
Copy link
Contributor

@jzuhone jzuhone commented Sep 10, 2018

This PR introduces improvements to FITS file writing and reading. Specifically:

  1. Specifies a new standard for writing metadata to FITS files using the FITSImageData class and its subclasses. This standard uses the header to write unit information and other metadata to the FITS file so that when it is read back into yt as a dataset it is more self-describing.
  2. Defines a new class, YTFITSDataset, which is a subclass of FITSDataset which looks specifically for this header metadata.
  3. Simplifies the logic in FITSHierarchy for determining units.
  4. Makes the "beam" unit part of SkyDataFITSDataset.
  5. Adds a convolve method to FITSImageData instances to convolve them with any kernel created using AstroPy or a simple Gaussian kernel.
  6. Specifies that the default image resolution for FITSImageData subclasses should be 512. The previous behavior was inconsistent across the various subclasses.

The new yt-based standard for writing FITS datasets with self-describing information and reading them back in as datasets is set out in a YTEP:

yt-project/ytep#5

Things left to do:

  • add built-in method to YTCoveringGrid to write these grids to FITS files
  • change docs
  • fix / add more tests
  • ensure consistency with analysis modules

@jzuhone
Copy link
Contributor Author

jzuhone commented Sep 18, 2018

@yt-fido test this please

John Zuhone and others added 27 commits April 17, 2019 11:26
@jzuhone
Copy link
Contributor Author

jzuhone commented Apr 17, 2019

Closing this because I've rebased on yt-4.0.

@jzuhone jzuhone closed this Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Triage needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants