ensure clump info is calculated when clumps are created #2053
Conversation
There was a problem hiding this comment.
This solution will add slightly to the computation time since the clump info items will be calculated by default instead of only after determining which clumps should survive, but that should be pretty minimal. We don't have any stock info items whose results could change over the course of the clump finding, but it's possible to imagine some. It might interesting in the future to implement on-demand calculation of the info items, but that can wait.
| return "Cell Volume: %6e cm**3.", total_vol | ||
| add_clump_info("total_volume",_total_volume) | ||
| master_clump.add_info_item("total_volume") | ||
|
|
||
| find_clumps(master_clump, 0.5, 2. * high_rho, 10.) | ||
|
|
||
| # there should be two children | ||
| assert_equal(len(master_clump.children), 2) | ||
|
|
||
| leaf_clumps = get_lowest_clumps(master_clump) |
There was a problem hiding this comment.
I suppose this is unrelated to this PR, but I realize that we just marked get_lowest_clumps as deprecated. Could you change this to master_clump.leaves?
There was a problem hiding this comment.
done, as well as a few other places we were still using it internally and in the docs.
|
@yt-fido test this please |
Currently the clump
infoattribute is only populated byclump.save_as_dataset. This PR makes it so that information is calculated for all clump objects when the clump is initially created.@brittonsmith I'd very much appreciate any insight you might have on whether this will have unintended consequences elsewhere.