install test requirements from requirements files. Fixes #2031. #2083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yt-fido test this please |
matthewturk
approved these changes
Nov 2, 2018
|
@yt-fido test this please |
added 8 commits
November 2, 2018 10:13
|
@yt-fido test this please |
ngoldbaum
changed the title
|
I removed the WIP label, I think this is ready now. I'm going to push some doc updates first though. |
|
@Xarthisius if you could look over the new docs I added in the last two commits I'd very much appreciate it. |
|
@yt-fido test this please |
Xarthisius
approved these changes
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the tests use two new requirements files
tests/test_requirements.txtandtests/test_minimal_requirements.txt. Rather than adding a singlerequirements.txtin the root of the package, I'm opting to add these to thetestsfolder to hopefully avoid confusing new users. Ultimately I'd like for there to only be one source of truth on this stuff so I've made it so Travis and Appveyor both install packages using these files. I'm initially working on getting travis and appveyor working using this setup. We'll also need to update jenkins as well but I'm waiting on that until Travis and Appveyor are working, as that will take separate coordination.