[bugfix] fix io chunking for chained cut regions #2234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewturk
requested changes
Apr 10, 2019
| if isinstance(data_source, YTCutRegion): | ||
| self.__init__( | ||
| data_source.base_object, | ||
| data_source.conditionals + conditionals, |
There was a problem hiding this comment.
I think ensure_list(conditionals) needs to happen before this
ngoldbaum
reviewed
Apr 10, 2019
| if isinstance(data_source, YTCutRegion): | ||
| self.__init__( | ||
| data_source.base_object, | ||
| data_source.conditionals + conditionals, |
There was a problem hiding this comment.
Calling __init__ inside of __init__ is a little weird to me. Is it possible to set data_source and conditionals in this if block and then set up the instance using the existing logic below?
Also I realize this is how it is already, but a straightforward cleanup would be to deprecate (with a visible warning) passing base_object in and to call the attribute data_source instead of base_object.
There was a problem hiding this comment.
Yeah, this can probably be simplified like that. I'll give it a go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This closes Issue #2233.
When chained cut regions do io chunking, only the conditionals of the last cut region are applied. Conditionals from parent cut regions are ignored. This only shows up when calculating derived quantities.
The solution implemented here changes how cut regions derived from other cut regions are initialized. Instead of creating a chain of objects that rely on each's parent, we add the conditionals from the parent cut region and create the new one from the parent's base object. Anecdotally, this also appears to speed up field access as we're only applying conditionals once.
PR Checklist