Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix set_buff_size issue for OffAxisProjectionPlot #2239

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Fix set_buff_size issue for OffAxisProjectionPlot #2239

merged 1 commit into from
Apr 17, 2019

Conversation

qobilidop
Copy link
Member

Fix #2238.

@qobilidop
Copy link
Member Author

Ping @tkc004.

ngoldbaum
ngoldbaum approved these changes Apr 16, 2019
View reviewed changes
Copy link
Member

@ngoldbaum ngoldbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is a really nice cleanup.

If another reviewer is worrying about the API change, OffAxisProjectionDummyDataSource is not public.

@jzuhone jzuhone merged commit 0550c23 into yt-project:master Apr 17, 2019
@tkc004
Copy link

tkc004 commented Apr 17, 2019

Thank you, Bili.

@qobilidop qobilidop deleted the off-axis-res branch April 17, 2019 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzuhone jzuhone jzuhone approved these changes

@ngoldbaum ngoldbaum ngoldbaum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

set_buff_size doesn't work for OffAxisProjectionPlot
4 participants
@qobilidop @tkc004 @jzuhone @ngoldbaum