-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ARMVAC] restore jet test #2360
[ARMVAC] restore jet test #2360
Conversation
current build error looks like an artifiact to me. |
Yeah it does look like an artifact. I retriggered those tests and we'll see if it shows up again. |
That test issue is also showing up in #2363 |
@yt-fido test this please |
Hey @neutrinoceros I don't think you need to rerun the tests through fido (though if that was your intent then feel free to disregard this message!). The command with yt-fido only retriggers the py2 and py3 tests on Jenkins (you can see which checks yt-fido has control over by hovering over the icons of each check), which are the last two checks listed. The tests on appveyor won't be rerun with that command. To retrigger those we need to go through the appveyor interface. The appveyor issue we're seeing is unrelated to this PR and is showing up in other PRs, so I'd be comfortable merging this with another approval. |
Thanks for the clarification ! |
I hope it helped/is helpful! I'm going to try to track down the other error on Monday! |
Ok, it looks like the appveyor issue is already fixed on master thanks to #2367! |
and the associated website PR is now closed :) |
@yt-fido test this please |
@munkm could you retrigger the appyvor checks please ? Otherwise the PR is ready to go :) |
I don't see the changes merged in this PR that fix the appveyor tests so I don't think they'll pass if I retrigger them. If you want them to pass you'll need to merge master into this PR, but I personally don't think that's necessary in this particular case. The py2 and py3 tests passed on this PR earlier, so the only thing we need is another approving review to merge it. |
After the acceptance of yt-project/website#69, the dataset stored on the website should be eligible to tests, so I'm uncommenting the corresponding test block