Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARMVAC] restore jet test #2360

Merged

Conversation

neutrinoceros
Copy link
Member

After the acceptance of yt-project/website#69, the dataset stored on the website should be eligible to tests, so I'm uncommenting the corresponding test block

@neutrinoceros neutrinoceros added the code frontends Things related to specific frontends label Nov 21, 2019
@neutrinoceros
Copy link
Member Author

current build error looks like an artifiact to me.

@neutrinoceros neutrinoceros added the help wanted Contributions from external projects' maintainers is particularly appreciated ! label Nov 21, 2019
@neutrinoceros neutrinoceros changed the title ARMVAC restore jet test [ARMVAC] restore jet test Nov 22, 2019
@munkm
Copy link
Member

munkm commented Nov 22, 2019

Yeah it does look like an artifact. I retriggered those tests and we'll see if it shows up again.

@munkm
Copy link
Member

munkm commented Nov 22, 2019

That test issue is also showing up in #2363

@neutrinoceros
Copy link
Member Author

@yt-fido test this please

@munkm
Copy link
Member

munkm commented Nov 23, 2019

Hey @neutrinoceros I don't think you need to rerun the tests through fido (though if that was your intent then feel free to disregard this message!). The command with yt-fido only retriggers the py2 and py3 tests on Jenkins (you can see which checks yt-fido has control over by hovering over the icons of each check), which are the last two checks listed. The tests on appveyor won't be rerun with that command. To retrigger those we need to go through the appveyor interface.

The appveyor issue we're seeing is unrelated to this PR and is showing up in other PRs, so I'd be comfortable merging this with another approval.

@neutrinoceros
Copy link
Member Author

Thanks for the clarification !

@munkm
Copy link
Member

munkm commented Nov 23, 2019

I hope it helped/is helpful! I'm going to try to track down the other error on Monday!

@munkm
Copy link
Member

munkm commented Nov 25, 2019

Ok, it looks like the appveyor issue is already fixed on master thanks to #2367!

@neutrinoceros
Copy link
Member Author

and the associated website PR is now closed :)

@neutrinoceros neutrinoceros removed the help wanted Contributions from external projects' maintainers is particularly appreciated ! label Nov 25, 2019
@neutrinoceros
Copy link
Member Author

@yt-fido test this please

@neutrinoceros
Copy link
Member Author

@munkm could you retrigger the appyvor checks please ? Otherwise the PR is ready to go :)

@munkm
Copy link
Member

munkm commented Nov 26, 2019

I don't see the changes merged in this PR that fix the appveyor tests so I don't think they'll pass if I retrigger them. If you want them to pass you'll need to merge master into this PR, but I personally don't think that's necessary in this particular case. The py2 and py3 tests passed on this PR earlier, so the only thing we need is another approving review to merge it.

@matthewturk matthewturk merged commit 3c57411 into yt-project:master Nov 26, 2019
@neutrinoceros neutrinoceros deleted the restore_jet_test_amrvac branch December 12, 2019 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code frontends Things related to specific frontends
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants