Modified artio frontend fields to ytep 0003 conv: Issue/2608/artio

[cavestruz]

PR Summary

Modified ARTIO variable names to YTEP-0003 conventions for Issue #2608

• modify fields such as HeIII density -> He_p2_density in line 53 of yt/frontends/artio/fields.py
• add old field names to yt/fields/field_aliases.py to allow for backwards compatibility using ds._setup_deprecated_fields()

Question: @Provider10 and I would like to make sure that folks using the other field names can easily use (and know to use) the back-compatibility functionality. We are open to any thoughts or suggestions for putting in a specific error message for ARTIO users to let them know that they are missing the if the ds._setup_deprecated_fields() if the user has not added it, which we can add before this PR is merged.

Addresses: Issue #2608

PR Checklist

• Code passes flake8 checker
• New features are documented, with docstrings and narrative docs
• Adds a test for any bugs fixed. Adds tests for new features.

[welcome]

Hi! Welcome, and thanks for opening this pull request. We have some guidelines for new pull requests, and soon you'll hear back about the results of our tests and continuous integration checks. Thank you for your contribution!

[neutrinoceros]

Thanks you for opening this !

Question: @Provider10 and I would like to make sure that folks using the other field names can easily use (and know to use) the back-compatibility functionality. We are open to any thoughts or suggestions for putting in a specific error message for ARTIO users to let them know that they are missing the if the ds._setup_deprecated_fields() if the user has not added it, which we can add before this PR is merged.

Disclaimer: I am unfamiliar with the way we maintain support to unconventional (violating YTEP-0003) field names.
It appears that they are indeed collected in yt/fields/field_aliases.py, in which case I don't see a way to add a warning specifically for ARTIO, but I would at least suggest to add comments to the new lines to clarify they were added in support to ARTIO.

After careful examination my take on this is that the code in Dataset.setup_deprecated_fields should be revised to include the warning, but this would affect all frontends equally so I believe it goes beyond the scope of this PR.

I would like to request a second opinion from someone more experienced. @brittonsmith, since you were the one to mention the violation of YTEP-0003 originally, could you give any feedback ?

[matthewturk]

Thank you for doing this!

[Provider10]

@neutrinoceros -@cavestruz and I are considering opening a new issue for the deprecated fields warning, unless someone else wanted to do that.

Also @brittonsmith and @matthewturk: can both this PR and PR #2604 be a squashed and merged to master so I can do analysis from the master branch?

[brittonsmith]

Sorry for taking so long to weigh in on this. The fields in yt/fields/field_aliases.py are yt-2.x field names that we probably should have removed altogether a long time ago. That said, I think putting them there is the quickest way to getting this PR merged as soon as possible. Adding machinery to allow frontend-specific deprecated fields should be relatively straightforward, but should not hold this up.

I'm in favor of merging this and creating an issue to remind ourselves that the new fields added to _field_name_aliases should be moved to the artio frontend if and when frontend-specific machinery for deprecated fields is implemented.

@neutrinoceros, I will approve this and if you agree, you can be the third approval and merge this.

[brittonsmith]

Let's also merge PR #2604 as well and maybe someone can follow up with a quick PR to add the correct field alias for H2 density. I'm pretty much out of time for today. @neutrinoceros, can you take care of this?

[neutrinoceros]

maybe someone can follow up with a quick PR to add the correct field alias for H2 density

not sure I understand what remains to be done actually. I'm okay to merge this however !

[welcome]

Hooray! Congratulations on your first merged pull request! We hope we keep seeing you around! 🎆