add a style check GH workflow

[neutrinoceros]

PR Summary

fix #2839

Here's what it look like when triggered on a PR against a master branch that already includes this file
neutrinoceros2#1

PR Checklist

• remove Travis linting

[neutrinoceros]

Welp so the checks are not triggered here, which means only the master version of workflows is used (makes a lot of sense actually).

Then did trigger on my fork though https://github.com/neutrinoceros/yt/runs/984493527?check_suite_focus=true
(and caught a flake8 error that I have no idea how we did catch earlier)

[matthewturk]

Any chance you could see what the time savings is if we consolidate the steps into a single job, so we only checkout once?

[neutrinoceros]

In fact I tried to do it as a single job originally, but it's actually longer because then it doesn't run in parallel.
Also, it's not desirable because in that config it just reports the first error and then gives up on other checkers.
What we're missing here is a "stage", not a job, but it seems to me that there's no such thing currently in GitHub workflows.

[matthewturk]

Ah, got it!

…

On Fri, Aug 14, 2020 at 7:33 AM Clément Robert ***@***.***> wrote: In fact I *tried* to do it as a single job originally, but it's actually longer because then it doesn't run in parallel. Also, it's not desirable because in that config it just reports the first error and then gives up on other checkers. What we're missing here is a "stage", not a job, but it seems to me that there's no such thing currently in GitHub workflows. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2862 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAVXO72FUQRSIVCY3KI2ADSAUVIHANCNFSM4P7L3YIA> .

[munkm]

This looks good to me!

[neutrinoceros]

Too bad this hit the current random failure on travis... It's not affecting the codebase itself but because it does affect the conf file for Travis, maybe the run should be retriggered ? Though I'm not sure if flipping a coin is worth 2.5 h of cpu time tbh.

[munkm]

I'll retrigger the travis tests. I can trigger individual jobs so it's only 30 minutes for osx.