Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix/flaking_ramses #2906

Merged
merged 1 commit into from
Sep 16, 2020
Merged

hotfix/flaking_ramses #2906

merged 1 commit into from
Sep 16, 2020

Conversation

cphyc
Copy link
Member

@cphyc cphyc commented Sep 16, 2020 •
edited
Loading

PR Summary

PR Checklist

  • pass black --check yt/
  • pass isort . --check --diff
  • pass flake8 yt/
  • pass flynt yt/ --fail-on-change --dry-run -e yt/extern
  • New features are documented, with docstrings and narrative docs
  • Adds a test for any bugs fixed. Adds tests for new features.

This should fix the flaking errors that's poping up in other PRs.

@cphyc cphyc added code style Related to linting tools code frontends Things related to specific frontends labels Sep 16, 2020
neutrinoceros
neutrinoceros approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@neutrinoceros neutrinoceros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks ! I wonder why this wasn't caught previously

@neutrinoceros
Copy link
Member

adding the "bug" label to satisfy mergeable bot

@matthewturk
Copy link
Member

It seems this might fix some cascading effects, so I'm merging.

@matthewturk matthewturk merged commit 63371f5 into yt-project:master Sep 16, 2020
@matthewturk matthewturk mentioned this pull request Sep 16, 2020
Merged
@cphyc cphyc deleted the hotfix/flaking_ramses branch January 13, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munkm munkm munkm approved these changes

@neutrinoceros neutrinoceros neutrinoceros approved these changes

Assignees
No one assigned
Labels
bug code frontends Things related to specific frontends code style Related to linting tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cphyc @neutrinoceros @matthewturk @munkm