Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update is_root and only_on_root functions. #3043

Merged
merged 3 commits into from
Jan 28, 2021
Merged

Update is_root and only_on_root functions. #3043

merged 3 commits into from
Jan 28, 2021

Conversation

brittonsmith
Copy link
Member

This updates the is_root and only_on_root functions for the new configuration.

PR Summary

PR Checklist

  • New features are documented, with docstrings and narrative docs
  • Adds a test for any bugs fixed. Adds tests for new features.

munkm
munkm approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@munkm munkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing branch name.

neutrinoceros
neutrinoceros approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@neutrinoceros neutrinoceros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 @munkm !

cphyc
cphyc approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@cphyc cphyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-read all the calls to ytcfg and convinced myself these two functions are the only one that needed an update.

I left two minor comments, but I'd fine to merge this as is.

yt/funcs.py Outdated Show resolved Hide resolved
yt/funcs.py Outdated Show resolved Hide resolved
@munkm munkm merged commit 4d6918c into yt-project:main Jan 28, 2021
@brittonsmith brittonsmith deleted the iamroot branch January 29, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewturk matthewturk matthewturk approved these changes

@cphyc cphyc cphyc approved these changes

@munkm munkm munkm approved these changes

@neutrinoceros neutrinoceros neutrinoceros approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@brittonsmith @matthewturk @cphyc @munkm @neutrinoceros