-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: simplify get_pbar by removing a vestigial class that's not used anymore #3115
Conversation
It is used in yt_astro_analysis. I am getting rid of it with some new changes, but maybe we can hold off on this so I don't have to fix yt-astro first. |
I think the fix is simply to replace any instance of |
Actually @brittonsmith , I went to yt_astro_analysis to try and it looks to mean it's not used there (anymore ?). |
8cf54bc
to
d8111ca
Compare
@brittonsmith let us know when this is fixed in astro_analysis and we can merge after that. |
I've double checked and I confirm that |
Looks like this is actually mergeable with 2 approvals ? @matthewturk @munkm ? |
For posterity, I finally remembered what package uses this. It's one of mine. I'll move the code there. |
PR Summary
related to YTEP-0039 but not part of it
I noticed the
parallel
flag fromyt.funcs.get_pbar
wasn't used anywhere so I removed the unnecessary code around it.(This will conflict with #3114. I'd like the present change to go in first)