Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: simplify get_pbar by removing a vestigial class that's not used anymore #3115

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

neutrinoceros
Copy link
Member

@neutrinoceros neutrinoceros commented Mar 8, 2021

PR Summary

related to YTEP-0039 but not part of it
I noticed the parallel flag from yt.funcs.get_pbar wasn't used anywhere so I removed the unnecessary code around it.

(This will conflict with #3114. I'd like the present change to go in first)

@neutrinoceros neutrinoceros added dead code removing internal bits that have no effect refactor improve readability, maintainability, modularity labels Mar 8, 2021
@brittonsmith
Copy link
Member

It is used in yt_astro_analysis. I am getting rid of it with some new changes, but maybe we can hold off on this so I don't have to fix yt-astro first.

@neutrinoceros
Copy link
Member Author

I think the fix is simply to replace any instance of ParallelProgressBar with DummyProgressBar
I can either submit a patch to yt_astro_anaylsis or deprecate de class here, what do you prefer ?

@neutrinoceros
Copy link
Member Author

Actually @brittonsmith , I went to yt_astro_analysis to try and it looks to mean it's not used there (anymore ?).

@munkm
Copy link
Member

munkm commented Mar 11, 2021

@brittonsmith let us know when this is fixed in astro_analysis and we can merge after that.

@neutrinoceros
Copy link
Member Author

I've double checked and I confirm that git grep ParallelProgressBar returns nothing on the master (and only) branch there.

@neutrinoceros
Copy link
Member Author

Looks like this is actually mergeable with 2 approvals ? @matthewturk @munkm ?

@munkm munkm merged commit d28d204 into yt-project:main Mar 29, 2021
@neutrinoceros neutrinoceros deleted the cleanup_deadclass2 branch March 29, 2021 15:50
@brittonsmith
Copy link
Member

For posterity, I finally remembered what package uses this. It's one of mine. I'll move the code there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dead code removing internal bits that have no effect refactor improve readability, maintainability, modularity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants