load_sample: update amrvac sample data files registry #3280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
force-pushed
the
update_amrvac_testfiles_registry
branch
from
02c695e
to
969aa69
Compare
neutrinoceros
force-pushed
the
update_amrvac_testfiles_registry
branch
from
969aa69
to
dbcd2d3
Compare
|
@matthewturk @jzuhone @Xarthisius I'm pinging you three for reviews since you've all been poking at this in the past, but you don't need to all have a look at this. |
Xarthisius
approved these changes
Jun 1, 2021
|
Apart from |
|
excellent, thank you ! |
This was referenced Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
in combination with yt-project/website#97, this should fix #3178
A point that is not clear to me is how to better approach the proposed migration on the testing side. I imaging go as follow:
@Xarthisius, any thoughts ?
Since the issue was caused by non standardised packaging, I had to regenerate the hashes for each file.
While I'm at it, I also register the solar_prom2d dataset, which is already on the website but lacking a registration in the pooch registry.
note: I realise that this update breaks alphabetical ordering of the json file entries, but the patch was hard enough to keep track on, so I figure it's preferable to stick to a minimal diff to ease reviews.