Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning labels on Enzo-E frontend. #3290

Merged
merged 1 commit into from
May 21, 2021

Conversation

brittonsmith
Copy link
Member

PR Summary

It's now been four years since the Enzo-P/E frontend was implemented and there have not been any fundamental changes to Enzo-E data in that time. I think it's safe to do this now.

PR Checklist

  • New features are documented, with docstrings and narrative docs
  • Adds a test for any bugs fixed. Adds tests for new features.

@brittonsmith brittonsmith added the code frontends Things related to specific frontends label May 21, 2021
@neutrinoceros neutrinoceros added the dead code removing internal bits that have no effect label May 21, 2021
@neutrinoceros
Copy link
Member

Added the dead code label to satisfy the mergable bot :)

Copy link
Member

@neutrinoceros neutrinoceros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthewturk matthewturk merged commit e308a1f into yt-project:main May 21, 2021
@brittonsmith brittonsmith deleted the ewarn branch May 25, 2021 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code frontends Things related to specific frontends dead code removing internal bits that have no effect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants