-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding notes about particle deposit fields. #3302
Merged
neutrinoceros
merged 3 commits into
yt-project:main
from
matthewturk:particle_deposit_docs
May 27, 2021
Merged
Adding notes about particle deposit fields. #3302
neutrinoceros
merged 3 commits into
yt-project:main
from
matthewturk:particle_deposit_docs
May 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doc build might be failing because I'm referencing a section that won't exist until #3293 goes in. |
Would this be the place to mention |
Sure -- would you mind suggesting a change?
…On Tue, May 25, 2021 at 8:31 AM John ZuHone ***@***.***> wrote:
Would this be the place to mention ParticleProjectionPlot or should that be somewhere else? We already have docs for it but it would be good to link it somewhere.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Yes, I'll do that. |
cphyc
approved these changes
May 27, 2021
Co-authored-by: Clément Robert <cr52@protonmail.com>
Co-authored-by: Clément Robert <cr52@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds -- and removes! -- documentation about particle deposit fields.
Fixes #2218.