update owls_subfind frontend and add some format flexibility #3325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brittonsmith
added
blocker
matthewturk
approved these changes
Jun 2, 2021
| @@ -4,9 +4,12 @@ | |||
| from yt.utilities.io_handler import BaseIOHandler | |||
| from yt.utilities.on_demand_imports import _h5py as h5py | |||
|
|
|||
| _pos_names = ["CenterOfMass", "CentreOfMass"] | |||
There was a problem hiding this comment.
I almost suggested changing this to be a tuple, and then I realized we may actually want it to be mutable.
jzuhone
approved these changes
Jun 2, 2021
|
@brittonsmith can you rebase this on main? Should fix the unrelated test failures. |
|
These are failing with no old answers. What do we have to do update that? |
This was referenced Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Resolves Issue #3307.
This updates the owls_subfind frontend to yt-4.0 io. I've also added some flexibility for specific file attributes and naming conventions to account for a variant of this frontend that was identified on the slack channel. This seems to work for the sample data I have for that.
PR Checklist