Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #3410 + #3687 to yt-4.0.x (image filename validation fixes) #3698

Merged
merged 2 commits into from
Dec 1, 2021

Conversation

neutrinoceros
Copy link
Member

PR Summary

Manual backport for #3687, this time with correct branching (after I made a mistake in #3697)

@neutrinoceros neutrinoceros added bug viz: 2D api-consistency naming conventions, code deduplication, informative error messages, code smells... labels Nov 29, 2021
@neutrinoceros neutrinoceros added this to the 4.0.2 milestone Nov 29, 2021
@neutrinoceros
Copy link
Member Author

I think I have to backport #3410 as well to pass tests. I'll bundle it there and reopen when CI is green

@neutrinoceros neutrinoceros marked this pull request as draft November 29, 2021 12:22
matthewturk and others added 2 commits November 29, 2021 13:24
…_format_support

ENH: determine compatible matplotlib backend semi-dynamically. Incidentally add support for .svgz image format.
@neutrinoceros
Copy link
Member Author

Looks like we ran into the random error reported as #3619
@yt-fido test this please

@neutrinoceros neutrinoceros marked this pull request as ready for review November 29, 2021 14:43
@neutrinoceros neutrinoceros changed the title Backport #3687 to yt-4.0.x Backport #3410 + #3687 to yt-4.0.x (image filename validation fixes) Nov 29, 2021
@matthewturk matthewturk merged commit bfd35d5 into yt-project:yt-4.0.x Dec 1, 2021
@neutrinoceros neutrinoceros deleted the backport_3687 branch December 1, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-consistency naming conventions, code deduplication, informative error messages, code smells... bug viz: 2D
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants