Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix a bug where PlotContainer.save would wrongfully ignore specified field extension #3687

Merged
merged 2 commits into from
Nov 29, 2021

Conversation

neutrinoceros
Copy link
Member

@neutrinoceros neutrinoceros commented Nov 20, 2021

PR Summary

fix #3677, see discussion therein

@neutrinoceros neutrinoceros added bug viz: 2D api-consistency naming conventions, code deduplication, informative error messages, code smells... labels Nov 20, 2021
@neutrinoceros neutrinoceros added this to the 4.0.2 milestone Nov 20, 2021
@neutrinoceros neutrinoceros marked this pull request as draft November 22, 2021 10:54
@neutrinoceros
Copy link
Member Author

switching to draft as I add/fix new tests

@neutrinoceros neutrinoceros force-pushed the fix_image_suffix branch 4 times, most recently from 0392431 to 081eeba Compare November 22, 2021 14:01
matthewturk
matthewturk previously approved these changes Nov 22, 2021
@neutrinoceros
Copy link
Member Author

Something terrible happened in image tests and I got a conflict + typing errors (most of them are not easily fixable, it seems, so I just went with type: ignore...)

@neutrinoceros
Copy link
Member Author

@yt-fido test this please

@neutrinoceros neutrinoceros marked this pull request as ready for review November 22, 2021 21:40
@cphyc cphyc merged commit ad89992 into yt-project:main Nov 29, 2021
@lumberbot-app
Copy link

lumberbot-app bot commented Nov 29, 2021

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout yt-4.0.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -m1 ad8999239ef64122ba1c9ff9a7ad8343130d4595
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #3687: BUG: fix a bug where PlotContainer.save would wrongfully ignore specified field extension'
  1. Push to a named branch:
git push YOURFORK yt-4.0.x:auto-backport-of-pr-3687-on-yt-4.0.x
  1. Create a PR against branch yt-4.0.x, I would have named this PR:

"Backport PR #3687 on branch yt-4.0.x (BUG: fix a bug where PlotContainer.save would wrongfully ignore specified field extension)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@neutrinoceros
Copy link
Member Author

The bug (#3677) is still present on the yt-4.0.x branch so I'll open a manual backport

neutrinoceros pushed a commit to neutrinoceros/yt that referenced this pull request Nov 29, 2021
BUG: fix a bug where PlotContainer.save would wrongfully ignore specified field extension
neutrinoceros added a commit to neutrinoceros/yt that referenced this pull request Nov 29, 2021
neutrinoceros added a commit to neutrinoceros/yt that referenced this pull request Nov 29, 2021
matthewturk added a commit that referenced this pull request Dec 1, 2021
Backport #3410 + #3687 to yt-4.0.x (image filename validation fixes)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-consistency naming conventions, code deduplication, informative error messages, code smells... bug viz: 2D
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: slice plot can not be saved in "pdf" format
3 participants