-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: fix a bug where PlotContainer.save would wrongfully ignore specified field extension #3687
Conversation
c08bbe1
to
1c4871e
Compare
switching to draft as I add/fix new tests |
0392431
to
081eeba
Compare
…methods would wrongfully ignore specified field extension
ae8177c
to
b139ac6
Compare
Something terrible happened in image tests and I got a conflict + typing errors (most of them are not easily fixable, it seems, so I just went with |
@yt-fido test this please |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
The bug (#3677) is still present on the yt-4.0.x branch so I'll open a manual backport |
BUG: fix a bug where PlotContainer.save would wrongfully ignore specified field extension
PR Summary
fix #3677, see discussion therein