-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: fix error messages in RAMSESDataset validation #3801
Conversation
53ac33a
to
95baacd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good improvement.
95baacd
to
d2ce0dc
Compare
@matthewturk sorry I just forced pushed again because I realised I made a mistake that could break |
e5dca76
to
ed7c7a3
Compare
ed7c7a3
to
f18304f
Compare
This took a surprising amount of iterations for me to understand enough of what the frontend actually expected so I can provide more useful error messages. So I think the problem Andrew actually had was that his data isn't stored in a dir that's named ValueError: Could not determine output directory from '/Users/robcleme'
Expected a directory name of form '(output|group)_(\\d{5})' I'll wait on his reply to see if he's indeed able to load his data after rearranging the files, but I expect that this is now sufficient to close the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ooops, I should have waited a bit more before merging, shouldn't I? |
I don't think so, why ? |
(If it turns out that the issue Andrew had was more complex I can always reopen the ticket) |
…1-on-yt-4.0.x Backport PR #3801 on branch yt-4.0.x (BUG: fix error messages in RAMSESDataset validation)
PR Summary
This adresses the surface problem reported in #3800, i.e., I'm demystifying errors raised by
RAMSESDataset
at validation timeExample 1
On main
This branch
Example 2
On main
This branch