Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: RAMSESDataset fails to load #3800

Closed
neutrinoceros opened this issue Feb 10, 2022 · 2 comments · Fixed by #3801
Closed

BUG: RAMSESDataset fails to load #3800

neutrinoceros opened this issue Feb 10, 2022 · 2 comments · Fixed by #3801
Labels
bug code frontends Things related to specific frontends

Comments

@neutrinoceros
Copy link
Member

Bug report

Bug summary

This was reported on the mailing list https://mail.python.org/archives/list/yt-users@python.org/thread/5CMIDJGXF452PX6IGBGAGMAE3RKEQYD3/

So I think there are at least two different problems there:

  • the error message is malformed
  • it is not informative enough (there are a couple reasons why RAMSESDataset._is_valid can be False, but here we're swallowing everything)
  • I guess the data should actually load, but there is not enough information in the original report to assess what's actually going on

I'll link this issue to the person who reported, so we can work together on the last point. Meanwhile, I can fix the first two on my own

@neutrinoceros neutrinoceros added bug code frontends Things related to specific frontends labels Feb 10, 2022
@neutrinoceros neutrinoceros added this to the 4.0.3 milestone Feb 10, 2022
@neutrinoceros neutrinoceros removed this from the 4.0.3 milestone Feb 10, 2022
@neutrinoceros
Copy link
Member Author

Taking this out of the milestone for now. The first bugfix is ready so it can easily be back ported, but the underlying problem has no solution yet so it shouldn't block a release.

@neutrinoceros
Copy link
Member Author

Andrews Wright uploaded the dataset here:
http://use.yt/upload/a4d14d4e

@neutrinoceros neutrinoceros linked a pull request Feb 11, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug code frontends Things related to specific frontends
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant