-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: fix an UnboundLocalError #3898
BUG: fix an UnboundLocalError #3898
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Do we need another quick release?
I wouldn't oppose that. Maybe give it a week or two in case we catch another new problem ? Feel free to setup a new milestone |
@matthewturk btw I think the code tour workflow is still broken in that the repo secret it's supposed to use doesn't exist ? For now I don't know how to make the job pass |
I'll fix the code tour in a subsequent PR - I think I messed up the GHA for it. |
4b813f6
to
312b3b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason we can't merge this? The code tour fixes seem fine.
You can merge, but I think we need a follow up fix |
312b3b1
to
97b431c
Compare
Actually I think I only needed to update the reference commit in the code tour. Should be good now. |
97b431c
to
bba9ef7
Compare
@matthewturk if you're up for it, I would like to backport this |
Sounds good.
…On Fri, May 6, 2022 at 7:23 AM Clément Robert ***@***.***> wrote:
@matthewturk <https://github.com/matthewturk> if you're up for it, I
would like to backport this
—
Reply to this email directly, view it on GitHub
<#3898 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAVXOYJCLHCUN2BBSBMRDLVIUFLTANCNFSM5TYSQVAQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@matthewturk this should be the last PR to merge before we can release 4.0.4 |
PR Summary
This is a follow up to #3816 where I missed a break statement, which can lead to an
UnboundLocalError
being raised, as noted by @Gustav-Madsen on Slack.