Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: re-add lost comments from setup.cfg #4273

Merged
merged 1 commit into from
Dec 29, 2022
Merged

MNT: re-add lost comments from setup.cfg #4273

merged 1 commit into from
Dec 29, 2022

Conversation

neutrinoceros
Copy link
Member

PR Summary

In #4271 I forgot to manually migrate comments contained in setup.cfg. This fixes that.

@neutrinoceros neutrinoceros added enhancement Making something better infrastructure Related to CI, versioning, websites, organizational issues, etc labels Dec 28, 2022
matthewturk
matthewturk reviewed Dec 28, 2022
View reviewed changes
Copy link
Member

@matthewturk matthewturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I seem to remember @chrishavlin having had some issue with this. Or am I misremembering?

@neutrinoceros
Copy link
Member Author

issues with what ?

@matthewturk
Copy link
Member

My memory is vague, but something about comments needing to be on different lines.

@neutrinoceros
Copy link
Member Author

Ah, maybe I see what you mean. Before migrating to pyproject.toml we actually had a minor issue with formatting because we were using setup-cfg-fmt (a formatter dedicated to setup.cfg), but it doesn't know how to preserve comments unless they are on the same line as actual data, which is why we adopted this format previously. It's true that the constraint is gone now so we can indeed move comments to separate lines if anyone cares. Let me know !

matthewturk
matthewturk previously approved these changes Dec 29, 2022
View reviewed changes
@neutrinoceros
Copy link
Member Author

rebased to resolve conflicts

@matthewturk matthewturk merged commit 980a056 into yt-project:main Dec 29, 2022
@neutrinoceros neutrinoceros deleted the hotfix_commented_dependencies branch December 29, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewturk matthewturk matthewturk approved these changes

Assignees
No one assigned
Labels
enhancement Making something better infrastructure Related to CI, versioning, websites, organizational issues, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@neutrinoceros @matthewturk