Skip to content

Conversation

@neutrinoceros
Copy link
Member

@neutrinoceros neutrinoceros commented Dec 27, 2022

PR Summary

Follow up to #3078, and prep for #4270

The heavy lifting is done by ini2toml. The only effective change is a bump in the minimal requirement for setuptools' version at build time.

@neutrinoceros neutrinoceros added enhancement Making something better infrastructure Related to CI, versioning, websites, organizational issues, etc labels Dec 27, 2022
Comment on lines 72 to 73
[project.entry-points."nose.plugins.0.10"]
answer-testing = "yt.utilities.answer_testing.framework:AnswerTesting"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not clear yet that this auto-migration will work. I'm hoping CI doesn't rely on it because it needs to be dropped or migrated to pytest eventually. If nothing break in the first run I'll try again with this section completely removed to see how things go.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's used only on GHA for answer tests, so I'll keep it in this PR but it can be removed when #4122 goes in

@neutrinoceros neutrinoceros marked this pull request as ready for review December 27, 2022 20:05
Copy link
Member

@matthewturk matthewturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Making something better infrastructure Related to CI, versioning, websites, organizational issues, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants