ENH: allow boxlib frontend to read 1D cylindrical datasets

[yut23]

PR Summary

Removes the check that disallows cylindrical coordinates in 1D. It looks like yt learned how to support these sometime since this code was added in 2014. It also fixes an error in _parse_header_file() introduced by #4641.

I tested against an example dataset output by https://github.com/AMReX-Astro/Castro/tree/main/Exec/hydro_tests/Sedov using inputs.1d.cyl, and the cell volumes checked out (proportional to 1/r).

PR Checklist

• New features are documented, with docstrings and narrative docs
• Adds a test for any bugs fixed. Adds tests for new features.

[neutrinoceros]

I'm triaging this as a bug fix for now because it removes a blocking problem to anyone who would need the functionality, and the change is currently very small, but let's re-assess once we see test go green again.

[neutrinoceros]

Actually, failures are clearly unrelated.

[neutrinoceros]

For what it's worth I've issued a fix for those failures at #4759

[neutrinoceros]

@yut23 can you rebase to current main so we can get CI green ?

[yut23]

It might make more sense to split out the _parse_header_file() fix into a separate PR, since that's an actual bug fix, while the rest is an enhancement.

[neutrinoceros]

Works for me, but I think this is also fine as is.

[yut23]

We should probably add a sample data set to test with. I'm not sure what the process for that is, though.

[neutrinoceros]

You're right. And storage basically free for a 1D dataset so let's do it.
You can use yt upload on the command line to share the data sample. Then open a PR to the yt-project/website repo (see previously merged ones for an example). You will also need to update the data sample yaml registry in this repo (you may do it within this PR).

[cphyc]

@yt-fido test this please.

[cphyc]

This looks good to me :)

[neutrinoceros]

there appears to be a problem with the new data sample:

import yt

ds = yt.load_sample("castro_sedov_1d_cyl_plt00150")
ds = yt.load_sample("castro_sedov_1d_cyl_plt00150")

fails with FileNotFoundError (the exception is raised on the first call if data is already installed, and on the second otherwise). I'm looking into it.