Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: update xarray integration test to use non-deprecated API #4759

Merged
merged 1 commit into from
Dec 12, 2023
Merged

TST: update xarray integration test to use non-deprecated API #4759

merged 1 commit into from
Dec 12, 2023

Conversation

neutrinoceros
Copy link
Member

PR Summary

Fix a FutureWarning emmited in all Python 3.12 CI jobs, from xarray.

FAILED yt/data_objects/tests/test_covering_grid.py::test_xarray_export - FutureWarning: The return type of `Dataset.dims` will be changed to return a set of dimension names in future, in order to be more consistent with `DataArray.dims`. To access a mapping from dimension names to lengths, please use `Dataset.sizes`.

@neutrinoceros neutrinoceros added bug tests: running tests Issues with the test setup labels Dec 12, 2023
@neutrinoceros neutrinoceros added this to the 4.3.1 milestone Dec 12, 2023
@neutrinoceros neutrinoceros mentioned this pull request Dec 12, 2023
Merged
2 tasks
@matthewturk
Copy link
Member

This looks right to me, but @chrishavlin should take a look.

chrishavlin
chrishavlin approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@chrishavlin chrishavlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, looks right to me too!

@neutrinoceros
Copy link
Member Author

then I'll merge this to restore CI back to a useful state. Thank you guys !

@neutrinoceros neutrinoceros merged commit e8d92ae into yt-project:main Dec 12, 2023
13 checks passed
@neutrinoceros neutrinoceros deleted the hotfix_xarray_warning branch December 12, 2023 16:34
meeseeksmachine pushed a commit to meeseeksmachine/yt that referenced this pull request Dec 12, 2023
@neutrinoceros @meeseeksmachine
Backport PR yt-project#4759: TST: update xarray integration test to u…
313c07c 
…se non-deprecated API
@meeseeksmachine meeseeksmachine mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrishavlin chrishavlin chrishavlin approved these changes

Assignees

@chrishavlin chrishavlin

Labels
bug tests: running tests Issues with the test setup
Projects
None yet
Milestone
4.3.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@neutrinoceros @matthewturk @chrishavlin