RFC: avoid usage of deprecated numpy.core namespace (numpy 2 compat) #4829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewturk
approved these changes
Feb 25, 2024
neutrinoceros
added
bug
refactor
|
All green, including jobs with oldest numpy we support, so merging ! |
meeseeksmachine
pushed a commit
to meeseeksmachine/yt
that referenced
this pull request
Feb 25, 2024
…py.core (numpy 2 compat)
neutrinoceros
added a commit
that referenced
this pull request
Feb 25, 2024
…9-on-yt-4.3.x Backport PR #4829 on branch yt-4.3.x (RFC: avoid usage of deprecated usage numpy.core (numpy 2 compat))
neutrinoceros
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Combined with #4806, this replaces usages of
numpy.corewith public API.Context:
np.corewas always private API, but in numpy 2.0, it was moved tonp._coreto make it clearer.np.corecontinues to be available as an alias for now but importing from it now triggers deprecation warnings. In the few places that we actually import it, we can now easily switch to public API, so let's.