RFC: replace vendored version of numpy.trapz with supported API in numpy 2 #4806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
added
bug
refactor
neutrinoceros
force-pushed
the
numpy2/trapezoid_renaming
branch
from
bca9ef3
to
3d5085d
Compare
|
@yt-fido test this please |
|
This is actually more than just a cleanup, as the |
neutrinoceros
force-pushed
the
numpy2/trapezoid_renaming
branch
from
3d5085d
to
999185b
Compare
|
rebasing to refresh CI. This is blocking to validate other numpy-dev fixes. Can I ask for a quick review @matthewturk ? |
neutrinoceros
force-pushed
the
numpy2/trapezoid_renaming
branch
from
999185b
to
9f36d8e
Compare
|
@yt-fido test this please |
meeseeksmachine
pushed a commit
to meeseeksmachine/yt
that referenced
this pull request
Feb 25, 2024
…rapz with supported API in numpy 2
neutrinoceros
added a commit
that referenced
this pull request
Feb 25, 2024
…6-on-yt-4.3.x Backport PR #4806 on branch yt-4.3.x (RFC: replace vendored version of numpy.trapz with supported API in numpy 2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Follow up to #4632
xref numpy/numpy#25738
This can be considered a bugfix since the previous solution (shipped in yt 4.3.0) erroneously circumvents NEP 18 implementations in
unyt.