-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: replace vendored version of numpy.trapz with supported API in numpy 2 #4806
RFC: replace vendored version of numpy.trapz with supported API in numpy 2 #4806
Conversation
bca9ef3
to
3d5085d
Compare
@yt-fido test this please |
This is actually more than just a cleanup, as the |
3d5085d
to
999185b
Compare
rebasing to refresh CI. This is blocking to validate other numpy-dev fixes. Can I ask for a quick review @matthewturk ? |
999185b
to
9f36d8e
Compare
@yt-fido test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good fix.
…rapz with supported API in numpy 2
…6-on-yt-4.3.x Backport PR #4806 on branch yt-4.3.x (RFC: replace vendored version of numpy.trapz with supported API in numpy 2)
PR Summary
Follow up to #4632
xref numpy/numpy#25738
This can be considered a bugfix since the previous solution (shipped in yt 4.3.0) erroneously circumvents NEP 18 implementations in
unyt
.