Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix iterator #68

Merged
merged 1 commit into from
Mar 5, 2021
Merged

Fix iterator #68

merged 1 commit into from
Mar 5, 2021

Conversation

cphyc
Copy link
Member

@cphyc cphyc commented Mar 2, 2021

This fixes the rockstar frontend, which was broken in recent version of yt as the iter function was removed.
The same behaviour can still be achieved the iter keyword.

@cphyc
Fix iterator
c8e8bf5 
The __iter__ function was removed in yt, but we can still iterate over timeseries using the iter keyword
brittonsmith
brittonsmith approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@brittonsmith brittonsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can give a day to catch anyone else's eye, but I think this should go in right away. Hopefully, we can get the docs build fixed up soon.

@brittonsmith brittonsmith merged commit 2ba32cd into yt-project:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brittonsmith brittonsmith brittonsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cphyc @brittonsmith