preprocessor directives followup #89
Conversation
|
draft for now (but feel free to look now, @matthewturk ). I went through a couple iterations of approaches, want to double check that I didn't leave behind unwanted code... but also wanted to push this up now :) |
|
oh, also a draft cause I didn't actually run the tests locally. oops. so will have to fix a few things. but right now: running |
| self.colormap_fragment = new_combo["second_fragment"] | ||
| self.vertex_shader = new_combo[ | ||
| "first_vertex" | ||
| ], self._program1_pp_defs.get_shader_defs("vertex") |
There was a problem hiding this comment.
tests are failing cause self._program1_pp_defs (and 2) can be None.
There was a problem hiding this comment.
Should we instead have them not allow none, and supply a default that is an empty preprocessor state?
There was a problem hiding this comment.
ya, I do think that'd be better!
This PR follows on #70 and
use_db) with a preprocessorUSE_DBdefinition. I'm actually not sure switching this to a pre-processor directive is better or worse, but it does nicely illustrate the functionality.