Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVERTED] Adds more flags when building tests #6

Merged
merged 3 commits into from
Apr 22, 2016
Merged

[REVERTED] Adds more flags when building tests #6

merged 3 commits into from
Apr 22, 2016

Conversation

kpp
Copy link
Contributor

@kpp kpp commented Apr 22, 2016

  • add compile flags -Wpedantic -Werror

@ytakano ytakano merged commit 746bba1 into ytakano:master Apr 22, 2016
@kpp
Copy link
Contributor Author

kpp commented Apr 22, 2016

@ytakano Well... I feel sorry, but I haven't finished my pull request yet. I marked it as "[Work In Progress]"... Could you revert the merge please?

ytakano added a commit that referenced this pull request Apr 22, 2016
@ytakano
Revert "Merge pull request #6 from kpp/pedantic_warnings"
4d1ea9c 
This reverts commit 746bba1, reversing
changes made to 714ba5c.
@ytakano
Copy link
Owner

ytakano commented Apr 22, 2016

reverted!

@kpp kpp changed the title [Work In Progress] Adds more flags when building tests [REVERTED] Adds more flags when building tests Apr 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpp @ytakano