Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle symbolic links to directories #41

Merged
merged 1 commit into from
Nov 6, 2022

Conversation

chfritz
Copy link
Contributor

@chfritz chfritz commented Nov 4, 2022

FileType is a bitmask, e.g., 66 is 64 | 2 aka a symlink and a directory.

It would be great if you could merge and publish a new version with this fix!

Thanks for porting this from Atom. I was an avid Atom user and this extension is an absolute must for me.

`FileType` is a bitmask, e.g., `66` is `64 | 2` aka a symlink *and* a directory.
@chfritz
Copy link
Contributor Author

chfritz commented Nov 4, 2022

Without this fix:
image

With this fix:
image

Copy link
Owner

@ytakhs ytakhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good👍 Thank you!

@ytakhs ytakhs merged commit 07f6430 into ytakhs:main Nov 6, 2022
@ytakhs
Copy link
Owner

ytakhs commented Nov 6, 2022

Released and published! 🎉

https://github.com/ytakhs/vscode-advanced-open-file/releases/tag/v0.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants