Update Output Problem(EMBEDDING YOUTUBE-DL) #28488
Comments
|
In windows, the exe cannot update itself directly. So youtube-dl opens a new process with a batch script which does the actual updating. The The relevant code: bat = os.path.join(directory, 'youtube-dl-updater.bat')
with io.open(bat, 'w') as batfile:
batfile.write('''
@echo off
echo Waiting for file handle to be closed ...
ping 127.0.0.1 -n 5 -w 1000 > NUL
move /Y "%s.new" "%s" > NUL
echo Updated youtube-dl to version %s.
start /b "" cmd /c del "%%~f0"&exit /b"
\n''' % (exe, exe, version_id))
subprocess.Popen([bat]) # Continues to run in the backgroundYou can either set a fixed sleep of ~10sec, or will need to watch if the subprocess has exited |
That's what I did, thanks for the info though |
This was referenced May 22, 2021
pukkandan
added a commit
to yt-dlp/yt-dlp
that referenced
this issue
May 25, 2021
Closes: #335, ytdl-org/youtube-dl#28488, ytdl-org/youtube-dl#5810, ytdl-org/youtube-dl#5994 In windows, a running executable cannot be replaced. So, the old updater worked by launching a batch script and then exiting, so that the batch script can replace the executable. However, this caused the above-mentioned issues. The new method takes advantage of the fact that while the executable cannot be replaced or deleted, it can still be renamed. The current update process on windows is as follows: 1. Delete `yt-dlp.exe.old` if it exists 2. Download the new version as `yt-dlp.exe.new` 3. Rename the running exe to `yt-dlp.exe.old` 4. Rename `yt-dlp.exe.new` to `yt-dlp.exe` 5. Open a shell that deletes `yt-dlp.exe.old` and terminate While we still use a subprocess, the actual update is already done before the app terminates and the batch script does not print anything to stdout/stderr. So this solves all the above issues
nixxo
pushed a commit
to nixxo/yt-dlp
that referenced
this issue
Nov 22, 2021
Closes: yt-dlp#335, ytdl-org/youtube-dl#28488, ytdl-org/youtube-dl#5810, ytdl-org/youtube-dl#5994 In windows, a running executable cannot be replaced. So, the old updater worked by launching a batch script and then exiting, so that the batch script can replace the executable. However, this caused the above-mentioned issues. The new method takes advantage of the fact that while the executable cannot be replaced or deleted, it can still be renamed. The current update process on windows is as follows: 1. Delete `yt-dlp.exe.old` if it exists 2. Download the new version as `yt-dlp.exe.new` 3. Rename the running exe to `yt-dlp.exe.old` 4. Rename `yt-dlp.exe.new` to `yt-dlp.exe` 5. Open a shell that deletes `yt-dlp.exe.old` and terminate While we still use a subprocess, the actual update is already done before the app terminates and the batch script does not print anything to stdout/stderr. So this solves all the above issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I can't parse the output that tells that the update has succeeded.(run from Qt QProcess)
When I run the update(-U), all the output I catch is this:
But with only that it can't be said for sure when the update has been completed since that info comes later:
There's no way to know how long after.
Is there a solution for this?
The text was updated successfully, but these errors were encountered: