-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternate Audoiomack URL scheme #29800
Comments
Please suggest actual URL examples, both successful and failing with yt-dl, that you can play in your browser. |
The successful URL is redirected to failing URL when opened in browser.
Supported URL:
|
So we can make the pattern in Then:
|
I found the problem extend to albums, too. New album URL scheme is
Successful URL:
|
Clearly a bit more sophistication is needed to avoid finding songs as albums or vice versa. In the pattern in extractor/audiomack.com (line 18) the id must either follow 'song/...' or contain '.../song/...':
and remove any '/song/' component from the resulting ID (line 51) as before:
Similarly for the album extractor, at line 77, the id must either follow 'album/...' or contain '.../album/...':
and remove any '/album/' component from the resulting ID (line 116):
|
As I was going to open a PR, turns out |
So does
|
Now what? Will I wait for these issues to resolve or make a PR with new regex ? @dirkf |
Same for me and the site says "This song cannot be found or has been removed." The failing test can be disabled with Apparently the playlist ID for an album can be retrieved as a number but should be a string, which can be fixed with this revised line 138:
The project admins (when they're about) like a PR to address one specific set of changes, so the dead URL can be ignored for your PR. You could justify including the line 138 change, which matches what's done for 'video' IDs. |
Now I have to correct a whole other stuff. Turns out the album in test case has 11 songs but expects 15 URL |
Everything done except........................ ,
|
The test is trying to match the 9th playlist item but there are only 2. I formatted the JSON output below.
|
Original PR: ytdl-org/youtube-dl#29810 Closes #1352, ytdl-org/youtube-dl#29800 Authored by: abdullah-if, dirkf
Here is the current audiomack regex
But audiomack has also this kind of URL
https://audiomack.com/\<uploader name>/song/<song name>
Using this type of URL load generic extractor and ultimately fails.
The pattern need to be updated
The text was updated successfully, but these errors were encountered: