Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor/audiomack] Updated URL regex, corrected invalid testcases,… #29810

Merged
merged 2 commits into from
Feb 5, 2022

Conversation

abdullah-if
Copy link

@abdullah-if abdullah-if commented Aug 17, 2021

… fixed bug

Co-authored-by: dirkf fieldhouse@gmx.net

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Resolve #29800, resolve #30290, contains following:

  • Updated URL regex. Both new and old URL are compatible.
  • Updated test case. Number of song in playlist was lesser than expected.
  • Updated test case. Playlist didn't contained test song. Added another.
  • Disabled test case. Link broken. Add another. See New test case for audiomack wrapper around soundcloud song #29808
  • Fixed bug. Convert id from integer to string

… fixed bug

Co-authored-by: dirkf <fieldhouse@gmx.net>
@dirkf
Copy link
Contributor

dirkf commented Aug 17, 2021

LGTM

Mistakenly forgot to edit a line in last commit.

Co-authored-by: dirkf <fieldhouse@gmx.net>
@dirkf
Copy link
Contributor

dirkf commented Nov 30, 2021

@freedom4JA wrote:

Is there also a way for playlists? played around a bit but don't worked on my side.

Indeed, I considered making an AudiomackPlaylistIE and had these findings:

  • playlists work the same as songs and albums with .../playlist/uploader/name being redirected to .../uploader/playlist/name

  • a static html playlist page only contains unpopulated playlist JSON, so an API would be needed

  • an obvious possible API endpoint corresponding to those used for songs and albums (www.audiomack.com/api/music/url/playlist/uploader/name) just redirects to the web page

  • the page itself uses api.audiomack.com/v1/playlist/uploader/name which needs OAuth parameters

  • the API endpoints used by the extractor for songs and albums don't seem to be documented anywhere now (only the .../v1/... endpoints as above).

Unless perhaps @heyitsxavier (who added the original API calls) can advise, an AudiomackPlaylistIE seems a bit tricky.

pukkandan pushed a commit to yt-dlp/yt-dlp that referenced this pull request Dec 20, 2021
@dirkf dirkf merged commit 16a3fe2 into ytdl-org:master Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On audiomack downloading don’t start Alternate Audoiomack URL scheme
2 participants